Fix a couple of issues when invoking Gallery from Suggested Edits. #5238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a couple of issues that stem from previous legacy conversions of code, and/or incomplete understandings of how the code is supposed to work:
FilePageActivity, but instead it tries launchingGalleryActivitywhich will never work because GalleryActivity is not intended for viewing an individual File: page.page/media-listendpoint to get the list of images. However, for some reason we're calling it with a specific revision (page/media-list/123456..) which breaks the caching of that endpoint. (Asking for a specific revision should only be done when absolutely necessary, not in the default case.)Phabricator:
https://phabricator.wikimedia.org/T383917